Flask support - Githubissues

honeybadger-io / honeybadger-python

Send Python and Django errors to Honeybadger.

https://www.honeybadger.io/

MIT License

15 stars 26 forks source link

Flask support #29

Closed ifoukarakis closed 6 years ago

ifoukarakis commented 6 years ago

Hi,

I'd like to suggest adding Flask support. This PR contains:

[x] A plugin that creates Honeybadger payload from Flask's request object
[x] A Flask extension that initializes Honeybadger using Flask's configuration object.
[x] The Flask extension may be configured to automatically report any exceptions to honeybadger.

ifoukarakis commented 6 years ago

Seems there's an issue with Python 3.2. I will fix it.

ifoukarakis commented 6 years ago

Hi,

I finally fixed tests failing under Python3.2. When it comes to Python 3, Flask requires python version > 3.2. I had to disable the tests for python 3.2.

Waiting for your comments!

joshuap commented 6 years ago

@ifoukarakis thanks--will review and get back to you!

emhoracek commented 6 years ago

Hi! Is this likely to be merged? I would like to use it in a project!

stympy commented 6 years ago

Yup, sorry, this got lost in the shuffle... we'll work on getting this merged and released soon.

emhoracek commented 6 years ago

@stympy I just tried using this branch on my project and it works great!

stympy commented 6 years ago

@emhoracek Awesome, thanks for the info!

stympy commented 6 years ago

@demsullivan What's the ETA on this?

demsullivan commented 6 years ago

Merged - a bit of housekeeping to do, and then will release a new version later today.

demsullivan commented 6 years ago

Hey @ifoukarakis - looks like the build failed after I merged it - perhaps something changed with Flask since you submitted the PR?

https://travis-ci.org/honeybadger-io/honeybadger-python/jobs/398354921

Any insights?

ifoukarakis commented 6 years ago

I'll have a look ASAP.

ifoukarakis commented 6 years ago

Created https://github.com/honeybadger-io/honeybadger-python/pull/30 to fix this.