search

honeybadger-io / honeybadger-python

Send Python and Django errors to Honeybadger.
https://www.honeybadger.io/
MIT License
15 stars 25 forks source link

ASGI middleware/plugin. #84

Closed stefanondisponibile closed 3 years ago

stefanondisponibile commented 3 years ago

Hello! I'm proposing the following PR that should close #78.

This PR adds ASGI applications support and a custom FastAPI route. I added some tests and update the documentation.

What do you think @joshuap and @Kelvin4664?

joshuap commented 3 years ago

I forgot to mention—we will also need to add a CHANGELOG.md entry before merging this (under the "Unreleased" heading).

Edit: I didn't mean to close the PR with this comment. 🤦 😁

stefanondisponibile commented 3 years ago

Hey @joshuap, thanks for your edits! I updated the changelog. :+1:

joshuap commented 3 years ago

Thanks!! @Kelvin4664 feel free to merge this if you think it's ready.

Kelvin4664 commented 3 years ago

Unable to install async-asgi-testclient. @stefanondisponibile is there something we should do different?

stefanondisponibile commented 3 years ago

Hey @Kelvin4664 , sorry but today I'm just on mobile and don't have a clear idea on why it is failing. I'll have a closer look and let you know my guess!