Hello,
I just noticed that with #84 I introduced a dependency issue with fastapi preventing the correct initialization of Honeybadger.
This was caused by the auto_discover_plugins functionality importing the contrib package, and therefore raising an error when fastapi is not installed in your environment.
This pull request fixes that issue, and requires explicitly importing the HoneybadgerRoute for the "advanced" apiRoute usage in FastAPI.
(The tests completed successfully because fastapi is a dependency in the test environment).
What do you think? Does this makes sense to you, @Kelvin4664 ?
Kelvin4664
commented
3 years ago
Hello, I just noticed that with #84 I introduced a dependency issue with fastapi preventing the correct initialization of Honeybadger.
This was caused by the
auto_discover_pluginsfunctionality importing thecontribpackage, and therefore raising an error whenfastapiis not installed in your environment.This pull request fixes that issue, and requires explicitly importing the
HoneybadgerRoutefor the "advanced"apiRouteusage in FastAPI.(The tests completed successfully because
fastapiis a dependency in the test environment).What do you think? Does this makes sense to you, @Kelvin4664 ?
Thank you!