search

honeybadger-io / honeybadger-ruby

Ruby gem for reporting errors to honeybadger.io
https://docs.honeybadger.io/lib/ruby/
MIT License
250 stars 146 forks source link

chore: experiments to see why jruby test is flakey #505

Closed halfbyte closed 1 year ago

halfbyte commented 1 year ago

Can't repro locally, throwing a couple of things at the wall to see if something sticks.

Here's what I'm trying:

subzero10 commented 1 year ago

@halfbyte My suggestion would be to time-bound this issue. If it's too hard to reproduce, then we can choose to ignore it for now and come back to it in the future.

halfbyte commented 1 year ago

@subzero10 I agree. I haven't been able to repro this locally (and to be fair, most of the time went into me setting up my local environment to be able to test with jruby), so I'll leave this as is for now. This PR did not fail the tests (and I made them rerun once) but this is not a sufficient indicator that the tiny change I made there actually makes a difference, so I am happy to close this one for now and maybe revisit at a later date.

(In other words: If you agree, feel free to just close this PR)