search

honeybadger-io / honeybadger-ruby

Ruby gem for reporting errors to honeybadger.io
https://docs.honeybadger.io/lib/ruby/
MIT License
250 stars 146 forks source link

feat: track exceptions in :solid_queue #526

Closed stympy closed 8 months ago

stympy commented 8 months ago

And any other ActiveJob adapters that come along :)

Fixes #518

joshuap commented 8 months ago

In the future we may be able to use the new Rails error reporting API to capture exceptions (we already integrate with it, but I don't know how it works with ActiveJob).

searls commented 8 months ago

Do I understand right that I can update the gem and remove my extra rescue_from(Exception) in my jobs?

stympy commented 8 months ago

Do I understand right that I can update the gem and remove my extra rescue_from(Exception) in my jobs?

Yup, that should work, though I didn't keep the controller value or the logging that you had.

segiddins commented 7 months ago

This change has caused the number of exceptions tracked from rubygems.org to explode. We have jobs with rescue_from handlers that handle specific exceptions, and after upgrading to 5.6.0 those are all now being reported to honey badger, even though we don't want them to be

stympy commented 7 months ago

This change has caused the number of exceptions tracked from rubygems.org to explode. We have jobs with rescue_from handlers that handle specific exceptions, and after upgrading to 5.6.0 those are all now being reported to honey badger, even though we don't want them to be

Have you tried 5.8.0, which includes 2237541da76904b65a9a921b95a01b00d8bb399d ?

segiddins commented 7 months ago

yes, we were on 5.8.0 https://github.com/rubygems/rubygems.org/pull/4598