honeybadger-io / honeybadger-ruby

Ruby gem for reporting errors to honeybadger.io
https://docs.honeybadger.io/lib/ruby/
MIT License
250 stars 146 forks source link

perf: don't insert middleware at all if they've been disabled #549

Closed bradleypriest closed 5 months ago

bradleypriest commented 5 months ago

Following up on my comment from 7 years ago.

https://github.com/honeybadger-io/honeybadger-ruby/commit/ab2c8cb71253b096d8fa82e71b83d0bf6ad7489e#r22137232

If I've disabled the middlewares I would like to not see them in rails middleware

stympy commented 5 months ago

I approved this before I saw that the tests were failing, but once the tests pass, I think this is ready to go. :)

bradleypriest commented 5 months ago

I had a bit of a play around and it looks like the Agent and Config should be instantiated at this point