search

honeybadger-io / honeybadger-ruby

Ruby gem for reporting errors to honeybadger.io
https://docs.honeybadger.io/lib/ruby/
MIT License
250 stars 146 forks source link

fix: access GoodJob config via Rails.application.config #554

Closed stympy closed 5 months ago

stympy commented 5 months ago

Setting GoodJob's error handler with config.good_job.on_thread_error= in an initializer doesn't change GoodJob.on_thread_error by the time our plugin gets loaded.

stympy commented 5 months ago

This workaround seems OK to me for Rails, but do people ever configure GoodJob directly?

I decided to ignore that possibility since this change is just about ActiveJob being used inside Rails. :)

joshuap commented 5 months ago

This workaround seems OK to me for Rails, but do people ever configure GoodJob directly?

I decided to ignore that possibility since this change is just about ActiveJob being used inside Rails. :)

ðŸ§