This adds a more comprehensive event listener for monitoring Karafka allowing the plugin to send more event and metrics data to Insights. The error reporting code has also been extracted to its own listener class and now monitors both consumers and producers.
To help facilitate the added complexities and increased data output of this change, I also added two new configuration parameters to allow for fine grained control.
karafka.insights.events — Defaults to true. Allows you to disable the plugin from automatically sending Insights events for consumer_consumed and error_occurred notifications.
karafka.insights.metrics — Defaults to true. Allows you to disable the plugin from collecting various aggregated metrics.
The following changes were also made:
Added min, max, avg, and latest values to the histogram payload.
All values passed to a metric can now use the value key. This allows for a more uniform interface when working with different metric types.
Before submitting a pull request, please make sure the following is done:
If you've fixed a bug or added code that should be tested, add tests!
This adds a more comprehensive event listener for monitoring Karafka allowing the plugin to send more event and metrics data to Insights. The error reporting code has also been extracted to its own listener class and now monitors both consumers and producers.
To help facilitate the added complexities and increased data output of this change, I also added two new configuration parameters to allow for fine grained control.
karafka.insights.events— Defaults totrue. Allows you to disable the plugin from automatically sending Insights events forconsumer_consumedanderror_occurrednotifications.karafka.insights.metrics— Defaults totrue. Allows you to disable the plugin from collecting various aggregated metrics.The following changes were also made:
min,max,avg, andlatestvalues to the histogram payload.valuekey. This allows for a more uniform interface when working with different metric types.Before submitting a pull request, please make sure the following is done:
rake specin the repository root.