feat: skip middleware, plugins, and exception reporting when exceptions are disabled

honeybadger-io / honeybadger-ruby

Ruby gem for reporting errors to honeybadger.io

https://docs.honeybadger.io/lib/ruby/

MIT License

251 stars 145 forks source link

feat: skip middleware, plugins, and exception reporting when exceptions are disabled #646

Closed stympy closed 1 week ago

stympy commented 1 week ago

This PR makes the exceptions.enabled configuration option work a little better by doing the following:

Skip loading ErrorNotifier and associated middleware
Skip hooking into Sidekiq, etc. to report exceptions
Abort sending any notifications when calling Honeybadger.notify

joshuap commented 1 week ago

@roelbondoc did you review any of the other plugins?

roelbondoc commented 1 week ago

@roelbondoc did you review any of the other plugins?

I went through all the plugins and this covers everything except for the ErrorSubscriber in the rails plugin.

However, there is a early return based on the config in Honeybadger::Agent#notify method that will prevent any calls so this would cover anything we missed including custom invocations in an application.