search

honeybadger-io / honeybadger-webpack

A webpack plugin to send sourcemaps to Honeybadger
MIT License
29 stars 7 forks source link

chore: fix husky integration #301

Closed Pierre-Do closed 3 years ago

Pierre-Do commented 3 years ago

Status

READY

Description

Since version 5, Husky doesn't take the package.json configuration. I believe Husky has been updated using depfu (e.g https://github.com/honeybadger-io/honeybadger-webpack/commit/810e7423cc6ff7db9673b28fb3cbea4ca8f9a704) without running the migration script.

See https://typicode.github.io/husky/#/?id=breaking-changes

This PR is based on Husky migration script: https://github.com/typicode/husky-4-to-6

Steps to Test or Reproduce

Checkout the branch and try to commit something!

image

joshuap commented 3 years ago

@Pierre-Do thanks for submitting this! To be honest, I don't remember when husky was introduced. @ParamagicDev is this something you're using? Personally I don't like auto-fixing in a pre-commit hook, and prefer for my editor to handle linting.

If no one has a strong preference, I'd vote to remove the extra dependency.

KonnorRogers commented 3 years ago

@joshuap I think I did add it...I can't recall though. I have no issues with removing it. I say go for it! Focus on shipping, not linting is what I always say!

Pierre-Do commented 3 years ago

Fewer dependencies is better. I'm closing this then!