search

honeybadger-io / honeybadger-webpack

A webpack plugin to send sourcemaps to Honeybadger
MIT License
29 stars 7 forks source link

Feat: add deploy notification #307

Closed KonnorRogers closed 3 years ago

KonnorRogers commented 3 years ago

Status

WIP!!!! Needs to add testing / documentation

Closes #278

Description

Sends a deploy notification when webpack successfully compiles.

Todos

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> npm test
Pierre-Do commented 3 years ago

Hey @ParamagicDev , any news on this? If there's a beta published with this feature I'd be happy to give it a go.

KonnorRogers commented 3 years ago

@Pierre-Do sorry I've been swamped with work recently. I haven't had a chance to add tests for this, but it should work. As far as I'm aware there's no release for this yet.

shalvah commented 3 years ago

Hey @ParamagicDev I've resolved conflicts and added some integration tests for this feature.

shalvah commented 3 years ago

No problem @ParamagicDev .👍

Btw: I noticed your implementation required environment, repository and localUsermame to be present, but the deployment API has them as "optional". I assume it was an oversight, so I've made them all optional (you can simply pass deploy: true to enable deployment notifications).

shalvah commented 3 years ago

Thanks @shalvah, looks good to me. Can you update the readme with the new config, and add a changelog entry?

@ParamagicDev do you want to take a look?

Done

joshuap commented 3 years ago

@shipjs prepare

github-actions[bot] commented 3 years ago

@joshuap shipjs prepare done