search

honeybadger-io / incoming

Incoming! helps you receive email in your Rack apps.
https://www.honeybadger.io/
MIT License
309 stars 19 forks source link

Sendgrid content transfer encoding #11

Closed jhecking closed 10 years ago

jhecking commented 10 years ago

Fix #10 by removing the Content-Transfer-Encoding header.

joshuap commented 10 years ago

Thanks! You mentioned that you had an open thread here:

https://community.sendgrid.com/sendgrid/topics/webhook_api_and_content_transfer_encoding_base64

I would love to see some acknowledgement from SendGrid regarding this issue; I +1'd your question for now. :)

Can you confirm that deleting the header fixes the garbled text issue in the meantime?

jhecking commented 10 years ago

Unfortunately SendGrid hasn't responded to my question on their forum yet.

I did add a test case that demonstrates the issue with a Content-Transfer-Encoding: base64 header. Try running that against a branch that doesn't have my fix yet.

In our production environment we have only observed this issue very rarely. And we haven't had a case since we patched our system. But I've done manual testing (in addition to the spec) to confirm that it fixes the issue.

joshuap commented 10 years ago

That's good enough for me; thanks for working on this. :thumbsup: