FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED flags are deprecated in PHP 7.3

honeybee / trellis

Library for defining structured entities in php.

Mozilla Public License 2.0

8 stars 1 forks source link

FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED flags are deprecated in PHP 7.3 #32

Open graste opened 6 years ago

graste commented 6 years ago

FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED flags are deprecated in PHP 7.3. See https://wiki.php.net/rfc/deprecations_php_7_3

MrHash commented 6 years ago

Did a quick search but didn't find usages. Is this deprecation relevant to this lib?

Pictor13 commented 6 years ago

The flags are implicitly used in filter_var(), when specifying FILTER_VALIDATE_URL. The explicit use of the flags is deprecated (since, as I understood from this SO, makes no difference; they'll be used anyway).

So dunno if there is actual code to fix (in the code we never specify those flags explicitly).

Additionally, there is a bug report related to that, but is still open so the deprecation is not because of this one being fixed.

graste commented 6 years ago

So you both probably did the work I intended for this ticket. :+1: I created the ticket as I saw the changelog and wanted to check whether there are side effects with the filter_var stuff we use.