[optimization] simple concat for prepending "app." - Githubissues

honeycombio / beeline-go

Legacy instrumentation for golang apps with Honeycomb

https://honeycomb.io

Apache License 2.0

74 stars 48 forks source link

[optimization] simple concat for prepending "app." #328

Closed lizthegrey closed 2 years ago

lizthegrey commented 2 years ago

Which problem is this PR solving?

Instrumentation overhead in Shepherd is a wee bit too high. (Sprintf is the number one allocation source in https://pyroscope.prod.hny.wtf/?query=shepherd.alloc_objects%7B%7D&from=now-30m)

Short description of the changes

Avoid using fmt.Sprintf for a very simple operation. This hopefully gets rid of some inefficiency/allocations that otherwise are plaguing shepherd at high volume.