honeycombio / beeline-go

Legacy instrumentation for golang apps with Honeycomb
https://honeycomb.io
Apache License 2.0
74 stars 48 forks source link

Downgrade go-sqlite3 to stable version #338

Closed malt3 closed 2 years ago

malt3 commented 2 years ago

Resolves #337

Which problem is this PR solving?

Short description of the changes

Removed go-sqlite3 from go.mod, ran go mod tidy.

MikeGoldsmith commented 2 years ago

Thank you for raising the issue & providing a fix - much appreciated.

Is there a reason you went for v1.14.9 instead of latest 1.14.15?

malt3 commented 2 years ago

Is there a reason you went for v1.14.9 instead of latest 1.14.15?

I just ran go mod tidy after removing the dependency from go.mod. This should be the result of go minimal version selection.

MikeGoldsmith commented 2 years ago

Sure, no problem. I wasn't sure if you'd picked a version or not. Let's go with this and we can select to upgrade at another time.