honeycombio / beeline-go

Legacy instrumentation for golang apps with Honeycomb
https://honeycomb.io
Apache License 2.0
74 stars 48 forks source link

pre-define capacities for rollups and TLFs #353

Closed lizthegrey closed 2 years ago

lizthegrey commented 2 years ago

Which problem is this PR solving?

Short description of the changes

a subsequent follow-up might be allowing passing a map in its entirety to github.com/honeycombio/libhoney-go.(*Event).AddField so that the map entries do not need to be added one at a time when merging the maps together.

Or, better yet, https://github.com/golang/go/issues/56182 could prevent this problem by giving us a more sensible API for mass additions to a map.