search

honeycombio / helm-charts

Helm repository and charts for Honeycomb
Apache License 2.0
30 stars 39 forks source link

Setup a higher level enabled flag for the refinery helm chart #141

Closed teaguecole closed 2 years ago

teaguecole commented 2 years ago

Is your feature request related to a problem? Please describe. Currently use the app of apps model with argocd to deploy applications across a number of clusters which allows core components to be deployed on a number of clusters. Often times when in development, we want to isolate deployment of an application to a single dev cluster. For helm charts we've written, we can modify the template to include an enabled flag i.e {{- if .Values.my-app-chart.enabled }} and thus set enabled to false for a Values file of higher precedence. However, refinery is a dependency for a larger parent chart and thus we don't have the template yaml, and can't make minute modifications to an upstream chart, in this case refinery.

Describe the solution you'd like An enabled flag for the entire chart.

Describe alternatives you've considered Setting replicaCount to 0, but I think we'll still end up with other resources like ConfigMaps,Services etc being created unecessarily.

Additional context

MikeGoldsmith commented 2 years ago

Thanks for raising the issue. We will add this to our backlog for prioritisation.

We're always welcoming of contributions, if you feel you want to tackle this, please do.