search

honeycombio / helm-charts

Helm repository and charts for Honeycomb
Apache License 2.0
30 stars 39 forks source link

fix: Use distinct annotation keys for checksums #189

Closed mikebryant closed 2 years ago

mikebryant commented 2 years ago

Which problem is this PR solving?

Currently both checksums use the same key, so only one is present in the resulting Deployment. This is leading to our Deployments not restarting on rule changes.

Short description of the changes

Change the key for the rules so it's distinct from the one for config.

How to verify that this has the expected result

Deploy the chart, observe that there are now 2 checksum annotations on the Pod instead of only one.

MikeGoldsmith commented 2 years ago

Closing in favour of #197