search

honeycombio / helm-charts

Helm repository and charts for Honeycomb
Apache License 2.0
30 stars 39 forks source link

docs: Fix the unit for metrics.interval #220

Closed DavidS-ovm closed 1 year ago

DavidS-ovm commented 1 year ago

Which problem is this PR solving?

setting metrics.interval to 300 leads to this startup log:

time="2023-01-26T16:26:25Z" level=info msg="Creating Metrics Service Runner..."  [...] interval=300ns

and LOTS of events sent to honeycomb

Short description of the changes

How to verify that this has the expected result

puckpuck commented 1 year ago

The field is a time.Duration field. So you can pass in things like 300s to it. We should update the table to indicate this instead of calling it a nanosecond field.

TylerHelmuth commented 1 year ago

@DavidS-om are you able to update the table based on @puckpuck's feedback?

DavidS-ovm commented 1 year ago

@TylerHelmuth I love honeycomb dearly, but I've fixed my problem and I do not know (nor want to know) what a time.Duration field is or can do.

TylerHelmuth commented 1 year ago

@DavidS-om thank you. I am going to close this PR in favor of https://github.com/honeycombio/helm-charts/pull/221