search

honeycombio / helm-charts

Helm repository and charts for Honeycomb
Apache License 2.0
30 stars 39 forks source link

docs: [refinery] Add MaxConnectionAge default to values.yaml #254

Closed mterhar closed 1 year ago

mterhar commented 1 year ago

Which problem is this PR solving?

The MaxConnectionAge default is 0 which leads to load balancers failing to re-balance GRPC connections to Refinery. This means that one node in a multi-node deployment receives all of the traffic and expends more resources than it should redirecting all the traffic while the other nodes sit idle.

This PR doesn't change the default but exposes it as a configuration that can be set so operators can be in a better position to fix the problem if they run into it.

Short description of the changes

Adds some new

How to verify that this has the expected result

You can use the helm template command to see that the config is present. When it comes to actually verifying the connections remain open, I haven't cracked that nut yet.

TylerHelmuth commented 1 year ago

This PR doesn't change the default but exposes it as a configuration that can be set so operators can be in a better position to fix the problem if they run into it.

To be clear, this PR is not necessary for the chart to be able to set this value - helm chart users are allowed to set this value in the values.yaml today. I see the value of this PR as showing users who read the default values.yaml that this is a configuration that Refinery allows.

mterhar commented 1 year ago

@TylerHelmuth Thanks for the feedback. I agree that it's just to help with future reference for refinery 1.x users.

Can you merge? I lack permission.