search

honeycombio / helm-charts

Helm repository and charts for Honeycomb
Apache License 2.0
30 stars 39 forks source link

[refinery] Force pods to recycle on rules changes #85

Closed MikeGoldsmith closed 2 years ago

MikeGoldsmith commented 2 years ago

Summary

Pods are not recycled when making changes to refinery sampling rules to a deployed cluster using helm upgrade. Refinery live-reloads changes to rules.yaml and does not strictly need a restart for the changes to be applied.

Changes to config.yaml doe result in pods being recycled.

However, this make it look like changes have not been applied to the cluster when looking at cluster health. This change adds a new pod annotation for the rules.yaml which ensures pods are recycled when rules.yaml are changed.

Changes

puckpuck commented 2 years ago

The referenced issue is to restart on config changes, but this is implementing something to modify on rules changes. Rules are all hot reloadable, and thus we shouldn't be doing this change.

MikeGoldsmith commented 2 years ago

Closing this for now as rules changed intentionally do not require pod recycling. We're going to make a docs update to describe how config and rules changes are handled instead.