honeycombio / helm-charts

Helm repository and charts for Honeycomb
Apache License 2.0
30 stars 39 forks source link

Add ingressClassName support for ingress in secure-tenancy #94

Closed yeukhon closed 2 years ago

yeukhon commented 2 years ago

Is your feature request related to a problem? Please describe.

Internally we have an ingress controller based on nginx. To use that feature we simply configure our values.yaml this way:

ingress:
--
  | enabled: true
  | ingressClassName: https-internal
  | hosts:
  | - host: foo.bar.com
  | paths: ["/"]
  | tls: []

However, the ingress did not work properly. My colleague pointed out that ingressClassName was missing in the manifest spec. This feature was added a while back.

spec:
  rules:
    - host: foo.bar.com
      http:
        paths:
          - backend:
              service:
                name: secure-tenancy
                port:
                  name: http
            path: /
            pathType: Prefix

Describe the solution you'd like

The spec should have been this way:

spec:
  ingressClassName: https-internal
  rules:
...

Describe alternatives you've considered N/A

Additional context

JamieDanielson commented 2 years ago

Thanks for reporting @yeukhon ! We'll take a look at this and add to our backlog for updating.