search

honeycombio / honeycomb-opentelemetry-go

Honeycomb's OpenTelemetry Go SDK distribution
Apache License 2.0
22 stars 7 forks source link

improve behavior of setting of custom endpoint #105

Closed JamieDanielson closed 1 year ago

JamieDanielson commented 1 year ago

follow up from #102

note: As a follow-up, we should review how endpoints are set because it should not require removal of http://. Also we should make sure it is as easy as possible (and clearly documented) to set the insecure option for similar use cases of sending to an endpoint within the network.

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

vreynolds commented 1 year ago

OTEL_EXPORTER_OTLP_INSECURE=true is honored by the distro

JamieDanielson commented 1 year ago

suggestion: fix in launcher for better experience (if http but using grpc, drop the http protocol)... propose issue upstream for better helper function for end user (if http but using grpc, drop the http protocol... OR ignore with logged error and use the default collector endpoint).

JamieDanielson commented 1 year ago

Docs have been updated for using the insecure option.

The rest of this issue (footguns with endpoints) are now split into https://github.com/honeycombio/otel-launcher-go/issues/9 and https://github.com/honeycombio/otel-launcher-go/issues/10 on the launcher.