Upgrading msgpack to v5

honeycombio / libhoney-go

Go library for sending data to Honeycomb

Apache License 2.0

58 stars 40 forks source link

Upgrading msgpack to v5 #127

Closed paulosman closed 3 years ago

paulosman commented 3 years ago

Addresses #115 and #77. Upgrading msgpack to v5, which also brings along support for non-Go modules users.

Changes in v5:

Encoding / Decoding of numeric keys in maps no longer supported
Various type changes - timestamps are no longer decoded as references, integers default to int8

paulosman commented 3 years ago

We convert integer keys in maps to strings, so I'm not worried about the lack of support for encoding integer keys:

https://github.com/honeycombio/libhoney-go/blob/main/libhoney.go#L646

paulosman commented 3 years ago

We convert integer keys in maps to strings, so I'm not worried about the lack of support for encoding integer keys:

https://github.com/honeycombio/libhoney-go/blob/main/libhoney.go#L646

It also appears that we do not ever depend on decoding timestamps using msgpack, so I'm becoming increasingly confident that we can release this with a minor release (e.g. no API changes for users of the library).