fix: don't crash on stream aborts, always add content length

honeycombio / libhoney-go

Go library for sending data to Honeycomb

Apache License 2.0

58 stars 40 forks source link

Closed lizthegrey closed 2 years ago

lizthegrey commented 2 years ago

Fixes crash from #154 caused by Read() after Close() -- tickled by https://go-review.googlesource.com/c/net/+/355491 (first introduced when Go x/net/http2 change backported to golang 1.17.3)
Fixes missing Content-Length parameter due to underlying bytes.Readers not being detected by Go standard library runtime type detection. https://cs.opensource.google/go/go/+/refs/tags/go1.17.5:src/net/http/request.go;l=890

lizthegrey commented 2 years ago

https://go.dev/play/p/mNGgU5JkY1G -- proof that the old NopCloser and pooledReader implementations weren't being properly detected.