honeycombio / libhoney-go

Go library for sending data to Honeycomb
Apache License 2.0
58 stars 40 forks source link

Dropped events show up as errors on the reponse queue #163

Open vreynolds opened 2 years ago

vreynolds commented 2 years ago

Initially discovered in https://github.com/honeycombio/agentless-integrations-for-aws/issues/96

When libhoney drops an event due to sampling, it puts an error on the response queue "event dropped due to sampling". This is confusing on the receiving end, because it's not really an error, nothing went wrong.

It seems this was implemented as an error, because of the limitation of the Response struct -- there's not really a better field to add the message that event was sampled out