feat: support classic-flavored ingest keys

honeycombio / libhoney-go

Go library for sending data to Honeycomb

Apache License 2.0

58 stars 40 forks source link

Closed jharley closed 7 months ago

jharley commented 7 months ago

We've now released Ingest Keys, but in order for them to work with Classic environments properly we need to update the key detection logic.

updates the Classic API Key detection logic to understand the shape of a Classic Ingest Key
makes the previously private Config.isClassic a public method (Config.IsClassic) to allow other projects to use this method and reduce the duplication of logic (i.e. beeline-go)

jharley commented 7 months ago

Second, if you check length manually and then remove the counts from the regexp, it runs literally 1000x faster (7 nS instead of 7 uS!)

Whoa! Thank you for this: that's huge. Will refactor the shape of the function