feat: support classic ingest keys

honeycombio / libhoney-js

Javascript library for sending data to Honeycomb

Apache License 2.0

49 stars 28 forks source link

Closed cewkrupa closed 5 months ago

cewkrupa commented 5 months ago

We've released Ingest Keys, but need to update the key detection logic to allow Ingest Keys to be used to send data to Classic environments.

updates the Classic API Key detection logic to understand the shape of a Classic Ingest Key
Changes isClassic from a "private" class method of Libhoney to a static class method, so we can reuse it in dependent libraries without repeating logic everywhere

MikeGoldsmith commented 5 months ago

Looks good and matches the other implementations. Just need to update the PR body 👍🏻