search

honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb
Apache License 2.0
11 stars 30 forks source link

drop Ruby 2.3 support #106

Closed robbkidd closed 3 years ago

robbkidd commented 3 years ago

Which problem is this PR solving?

107 Address a general falling-behindedness.

Short description of the changes

Based on #104, so the diff for this PR against main includes all the changes from that PR, too. Comparing the two branches instead will focus on just the changes introduced in this PR.

This takes the minimum Ruby version up from 2.3 to 2.4. Largely a Rubocop update—into the stable 1.x release range, but still not the latest version—and adjustments to style or style rules for the new target Ruby version.

As is my wont, walking the commits from earliest to latest tells a story of each discrete change.

robbkidd commented 3 years ago

Rebased against main after #104 was merged. Increases signal, decreases noise in reviewing these changes.