search

honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb
Apache License 2.0
11 stars 30 forks source link

Try faraday without net-http-persistent #16

Closed eanakashima closed 7 years ago

eanakashima commented 7 years ago

Some local testing with memory profiler reveals that the net-http-persistent faraday adapter can leak threads when running our example script.. This switches to the Net::HTTP adapter, which seems to be better-behaved. It's unclear whether it's a bug in how we were using the adapter, or something with some version of the adapter itself, but attempting to dig further into the adapter code was not a fruitful line of inquiry for me. 🤔

eanakashima commented 7 years ago

Closing in favor of an approach that reverts back to the old http adapter; seemed to be more stable in terms of memory usage.