Go back to using http gem as http adapter

honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb

Apache License 2.0

11 stars 30 forks source link

Go back to using http gem as http adapter #18

Closed eanakashima closed 7 years ago

eanakashima commented 7 years ago

Alternative to https://github.com/honeycombio/libhoney-rb/pull/16 Our Faraday usage seems potentially correlated to user-reported memory leaks that have been difficult to reproduce & debug. The older adapter did not show the same behavior. We're thinking it may simplify things to go back to using the prior one.

eanakashima commented 7 years ago

👍 thanks for catching those duplicate keys. I definitely would like to come back to Faraday soon, especially if we can find a test case to reproduce the leak with the default Faraday adapter (Net::HTTP). The goal here is just to get a release out the door that brings back the best of past libhoney-rb releases.

samstokes commented 7 years ago

Yup, agree completely. My comment about coming back to Faraday was more wistful than productive.