search

honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb
Apache License 2.0
11 stars 30 forks source link

Ensure transmission threads are _alive_, as well as existing #30

Closed isaacseymour closed 6 years ago

isaacseymour commented 6 years ago

In TransmissionClient, ignore any non-alive threads from consideration before checking that threads are running. Otherwise @threads can end up holding a load of references to dead threads but still pushing stuff into the send queue that will never be consumed :sad_panda:

samstokes commented 6 years ago

One day I hope to tune up the thread pool exception handling so that we don't have threads silently dying for any reason, but until that fated day, this is a big improvement on the current behaviour. Thank you!

samstokes commented 6 years ago

I've released v1.10.1 that includes this fix.