Handle full response queue on close

honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb

Apache License 2.0

11 stars 30 forks source link

Handle full response queue on close #44

Closed martin308 closed 5 years ago

martin308 commented 5 years ago

If the response queue is full when close is called and there is nothing waiting on the response queue then it causes a deadlock. Handle this by respecting the block_on_responses flag and suppressing the error raised when the queue is full.

eanakashima commented 5 years ago

I ... am not sure why only ruby 2.6 has a failure for the new test 🤔

martin308 commented 5 years ago

🤔 potentially more threading issues, I'll try rerun it to see if it reliably fails. It doesn't locally.

martin308 commented 5 years ago

It passed 😢 There must be some other threading related problem here, I'll see if I can figure out why this would fail

maplebed commented 5 years ago

pulling myself off this review. It looks good, but I don't understand the question toshok's asking, so ... I think that means I shouldn't stamp. But it does look fine to me. fwiw.