flush events properly at low event throughputs

honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb

Apache License 2.0

11 stars 30 forks source link

flush events properly at low event throughputs #58

Closed tcrayford closed 4 years ago

tcrayford commented 4 years ago

at low event throughput, the while loop in batch_loop that receives events can fail to flush, because there's repeatedly a new event waiting for it.

I verified this locally using bundle open and added a bunch of print statements to transmission.rb. Without this line, the while loop can sit for a long time, never flushing any events out.

I have not yet dug into the test suite for this library to understand how to test/reproduce this issue

martin308 commented 4 years ago

@MikeGoldsmith we're still looking into this, but right now it seems like #59 is the better solution for this problem. Discussing more with @tcrayford tomorrow

martin308 commented 4 years ago

This was resolved with #59