honeycombio / libhoney-rb

Ruby library for sending data to Honeycomb
Apache License 2.0
11 stars 30 forks source link

sampling broken - multiplies event count instead #6

Closed josler closed 7 years ago

josler commented 7 years ago

https://github.com/honeycombio/libhoney-rb/blob/master/lib/libhoney/event.rb#L80-L87

This code does not return after marking an event to be sampled out, sending every event instead. This has the effect of multiplying the count of each event sent to Honeycomb (as the server is getting notified that the event was presampled, when it wasn't).