search

honeycombio / loadgen

A flexible command-line load generator to create traces in OTel or Honeycomb formats
Apache License 2.0
6 stars 2 forks source link

chore(deps): update Go OTel SDK #40

Closed lizthegrey closed 10 months ago

lizthegrey commented 10 months ago

Which problem is this PR solving?

Short description of the changes

lizthegrey commented 10 months ago

I like the work you've done in the upstream OTel SDK but I think we should wait for it to merge before we use it here. It may change further or even be rejected and we'd diverge from the SDK.

Unfortunately, this is necessary for my load testing as without the fix I'm unable to generate enough load to saturate refinery.

MikeGoldsmith commented 10 months ago

How are you conducting the tests? I think building or running the loadgen from this branch should be okay to run tests with the fix, it just means merging main back into this branch to make sure it has everything.

I'm only reluctant because until it merges, we'll need to open new PRs for each subsequent commit and we all know some PRs can take some tweaking and lobbying to get merged in OTel.

lizthegrey commented 10 months ago

How are you conducting the tests? I think building or running the loadgen from this branch should be okay to run tests with the fix, it just means merging main back into this branch to make sure it has everything.

I'm only reluctant because until it merges, we'll need to open new PRs for each subsequent commit and we all know some PRs can take some tweaking and lobbying to get merged in OTel.

A maintainer has taken responsibility for it to the point of filing an issue for go1.20 cleanup after it is merged :) should get merged in the next day or so, and in the meanwhile this is not a public repo, and is in use nowhere else in Honeycomb yet besides my test.

https://github.com/open-telemetry/opentelemetry-go/issues/4819

lizthegrey commented 10 months ago

Used a cherry-pick on top of v1.21.0 in case there are any problems lurking in otel-go at main.