fix(generator): do not share fielders between goroutines - Githubissues

honeycombio / loadgen

A flexible command-line load generator to create traces in OTel or Honeycomb formats

Apache License 2.0

3 stars 2 forks source link

fix(generator): do not share fielders between goroutines #41

Closed lizthegrey closed 8 months ago

lizthegrey commented 8 months ago

Which problem is this PR solving?

38 is caused by sharing of the same *Fielder between all goroutines. random.RNG is not safe to share without locking, but locking would be prohibitively expensive for us.

Short description of the changes

Prevents crash under extremely high TPS loads where many generator goroutines are running. Fixes #38.

lizthegrey commented 8 months ago

Review comments addressed, landing.