search

honeycombio / opentelemetry-collector-configs

Honeycomb Metrics-flavored OpenTelemetry Collector configuration
Apache License 2.0
7 stars 4 forks source link

[otel collector] Create a timestamp processor that snaps timestamps to the nearest <duration> #2

Closed mollystamos123 closed 3 years ago

mollystamos123 commented 3 years ago

Summary: Adds a new timestamp processor to the project that takes each metric datapoint's timestamp and snaps it to the nearest duration (where duration is specified in the config file).

This PR also includes code to generate the proper config to include the timestamp processor.

Test Plan: Unit tests & Manual testing

hazeledmands commented 3 years ago

Hey @MikeGoldsmith, just catching up here. You have good questions.

This repository's original aim was to create collector configs. This adds and hosts a custom processor and means this repository's reach and stability is different than before. I don't believe we have any go module version management in this repo, should these live in a different repo?

Ultimately I think the correct place for this processor is in https://github.com/open-telemetry/opentelemetry-collector-contrib, not this repository. But it's also pretty important for us to have a solution now that customers can use to keep their repackaging ratio as small as possible, hence why it lives here currently. One of the next steps for this is to start a conversation with the otel collector SIG about getting this processor merged into that project. Presumably they'll have some interesting feedback about it, also.

Taking additional context about visibility offline, given that this is now a public repo :)