search

honeycombio / terraform-honeycombio-opentelemetry-starter-pack

A terraform starter pack for creating honeycomb nouns for standard opentelemetry data
Other
5 stars 2 forks source link

Add derived column for better visibility into database spans #9

Closed tdarwin closed 1 year ago

tdarwin commented 1 year ago

Short description of the changes

This basically updates the db.system query in the All Services Board to use a derived column which will output the db.system or db.type field when a database call is being made. The db .system field is preferred, but some libraries/auto-instrumenters don't populate that (looking at you Elixer), so it will fill in db.type when system is unavailable.

irvingpop commented 1 year ago

Dope! What do you make of these test failures? is it just not cleaning up from past runs?

tdarwin commented 1 year ago

@irvingpop it's failing because of version 0.12.0 of the Terraform Provider. It won't update existing columns if they're in the dataset. The provider also doesn't actually delete columns (it's a no-op on destroy), so unless I manually clean up the environment, this is going to fail every time.