Fixed layout should be dynamic

honeynet / ochi

https://ochi.mushmush.org

GNU General Public License v3.0

25 stars 15 forks source link

Fixed layout should be dynamic #16

Open glaslos opened 1 year ago

glaslos commented 1 year ago

The App.svelte has a lot of hard-coded layout glory. This makes is rather difficult to add new layout elements without breaking the current layout. Even adding new pages would be challenging. Here are some offenders:

Redo the layout allowing for:

Dynamically resize the window
Adding more elements (like separating the right column)
Adding a new page (e.g. rule management, user profile...)

aditygrg2 commented 1 year ago

Hi @glaslos, I want to work on this, can you please elaborate on what is really required in this? I understood that the layout needs to be modified in order to allow for more elements and pages, I didn't understand the second paragraph on what really needs to be done.

glaslos commented 1 year ago

Have a look at the current layout definition. A lot of it depends on hard coded values defining the size of e.g. the header and the columns. The layout should be more elastic and based on the size of the content instead. E.g. We could allow for the divider between the left and right column to be manually adjustable. The header growing in size with more dynamic content being added.

aditygrg2 commented 1 year ago

Hi @glaslos, Thank you, I am facing some issues in implementing the sockets in localhost here : https://github.com/glaslos/ochi/blob/5e76a4b36ee9c532fbddb57a8455c1c550d3c9f5/src/App.svelte#L52

Also, I would like to contribute to GSoC this year, any issues or suggestions for understanding the codebase better will help me a lot, if you can suggest.

glaslos commented 1 year ago

Can you elaborate on your issues with the websockets? Are you running the backend server?

aditygrg2 commented 1 year ago

Hello @glaslos,

I have thought of an idea to maintain newer pages, as well as improve the current page layout. The wireframes are below:

After clicking on any event, the payload may appear separately on the right portion, the user can close or open it according to his/her needs.

We can implement more pages, in the left portion. Is this a good solution to this, do you have other suggestions/additions to this?

ashutosh887 commented 1 year ago

@glaslos I would like to work on this!