search

honeynet / ochi

https://ochi.mushmush.org
GNU General Public License v3.0
25 stars 15 forks source link

Format code before commit #39

Closed suyashvsingh closed 1 year ago

suyashvsingh commented 1 year ago

Follow up to #37

I have forked the repository again, and started afresh. The package-lock.json has got many new entries due to installing husky and lint-staged packages. It is not happening due to the package-lock.json getting formatted, as I have added json to .prettierignore.

As a follow up to the last review:

  1. Excluded ymlfrom prettier.
  2. Explained why I ran npx lint-staged instead of npx prettier --write .
  3. Removed the extra line that I added while testing the formatter.
glaslos commented 1 year ago

You are still changing the package lock file Ah, just read your message...

glaslos commented 1 year ago

@suyashvsingh I have been contemplating this suggestion for a while now and decided to not merge this change for now. I don't think this is generally a bad idea but I would like to keep working on this project as simple as possible for now with as little tools involved as possible. Let's reconsider in a while if we see formatting becomes a bigger issue.