honeynet / ochi

https://ochi.mushmush.org
GNU General Public License v3.0
27 stars 15 forks source link

improve filter input #59

Closed mushroomgenie closed 1 year ago

mushroomgenie commented 1 year ago

Fixes #55

mushroomgenie commented 1 year ago

@glaslos Was able to increase the width and add a reset query button on focus. Needed some clarity on the multiline input.

glaslos commented 1 year ago

Nice work! Regarding your question: Currently if you exceed the width of your input field, the text is pushed to the left out of the input field. I'd suggest wrapping the text and adding a new line. We should also "shrink" the field once it loses focus to not impact visibility on the page.

dkumiszhan commented 1 year ago

I am not sure if making input expandable now is useful. In the original version and Greynoise the query is within the header and by default does not occupy the whole line. There, it might be useful to expand the input. In the current version, there is nothing else on the same line next to the input. So I think we can consider 2 options:

  1. Move the filter input back to the header and do the expandable approach similar to what you are doing.
  2. Keep the filter input where it is but make it more expanded by default without the dynamic expanding.

Also it doesn't seem to apply filter when the input is expanded and "Reset Query" button doesn't remove all filters. I like how the reset button shows up on Greynoise. It would be nice if we could do something like that.

Could you also please fix the commits history, and rebase your code on top of what is already merged?

glaslos commented 1 year ago

@mushroomgenie how about going for option 2 suggested by @dkumiszhan ?

mushroomgenie commented 1 year ago

@glaslos sure we can do that.

glaslos commented 1 year ago

Closing due to inactivity