search

honeytrap / honeytrap

Advanced Honeypot framework.
https://docs.honeytrap.io/
Other
1.23k stars 174 forks source link

Load configuration file from system path #195

Closed athos-ribeiro closed 6 years ago

athos-ribeiro commented 6 years ago

As pointed in #136, it would be nice to have honeytrap to also look for a configuration file in a FHS compatible path. This would allow honeytrap system installations, like installing it from distriburion packages, like .deb or .rpm.

/etc/honeytrap/config.toml seems to be a good start. To avoid backwards incompatibility, it could either look for the file in the current work dir (this is the default right now) and fall back to the system path if it cannot find the file, or do the opposite, looking in the system path first and then falling back to the current directory.

nl5887 commented 6 years ago

Currently we can use the --config to define the location of the config file. Would that be sufficient?

athos-ribeiro commented 6 years ago

That works, but in this case it makes no sense to install a config file in the configuration system directory (/etc) since the user will always have to specify a path anyway. If this is the desired interface (no default to system path), we could ship the config.toml.sample file as part of the package documentation.

The package provided in #136 is fully functional as long as you pass the configuration file whenever running honeytrap.

nl5887 commented 6 years ago

Yes, absolutely. We can adjust the code use /etc/honeytrap/config.toml if exists and not overruled.