search

hongaar / unveil2

:mount_fuji: A very lightweight jQuery plugin to lazy load images
http://nabble.github.io/unveil2
38 stars 11 forks source link

Custom attribute #25

Closed vogdb closed 7 years ago

vogdb commented 7 years ago

Hi! Sometimes in legacy systems we might have a different attribute for source of image like data-original or data-img-source. For those cases it would be great to have this customisation.

vogdb commented 7 years ago

@hongaar please review

hongaar commented 7 years ago

Thanks, that'd be a great addition. Do you think we should also make data-src-placeholder configurable then?

vogdb commented 7 years ago

Well, to be honest I would not complicate without the real need :) Legacy systems usually don't provide such advanced attributes. Lets skip it for now. Are you fine with the name attribute? I also forgot to adjust docu. Will fix it.

hongaar commented 7 years ago

Looks good, thanks for the PR!

vogdb commented 7 years ago

thanks for such short notice!