search

hongaar / unveil2

:mount_fuji: A very lightweight jQuery plugin to lazy load images
http://nabble.github.io/unveil2
38 stars 11 forks source link

Replace grunt-contrib-qunit #26

Closed vogdb closed 7 years ago

vogdb commented 7 years ago

Hi @hongaar ! grunt-contrib-qunit uses a very very outdated qunit 1.18.0 which does not support even nesting inside Qunit.module. Its updating seems to be postponed gruntjs/grunt-contrib-qunit#123. What do you think about grunt-contrib-jasmine? Offtopic. Wdyt about changing grunt to gulp?

vogdb commented 7 years ago

Also we can not use qunit-fixture feature cause it has unacceptable styles for purposes of this library.

hongaar commented 7 years ago

I have no experience with jasmine, but I'd be more than happy to accept a PR for this. Also the tests use only jQuery 2, maybe it'd be nice to also test with jQuery 3?

Switching from grunt to gulp is certainly nice to have, but I think the disadvantages of Grunt (mainly speed) are not really a problem in this repo?

vogdb commented 7 years ago

I have no experience with jasmine, but I'd be more than happy to accept a PR for this.

Don't worry I will do it but I'm not sure about jasmine. I will quickly look over all popular test libraries.

Switching from grunt to gulp is certainly nice to have, but I think the disadvantages of Grunt (mainly speed) are not really a problem in this repo?

The main disadvantage here that grunt receive less support than gulp. For example grunt-contrib-qunit which kind of stucked in its support and currently outdated.

vogdb commented 7 years ago

in favor of #28