search

hongee / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 0 forks source link

Code review: mikesamuel/fix-bug-234 (49 added, 0 removed, 14 changed) #235

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
gvn review mikesamuel/fix-bug-234

*mikesamuel/fix-bug-234@1240 | mikesamuel | 2008-04-29 20:36:01 -0800 (Tue,
29 Apr 2008)

Description:

I did a bit of memory profiling and fixed some low hanging fruit.  I
think there's still a lot more that can be done to make parse tree
node cloning light-weight, but now rule execution is showing up
towards the top of the hotspot list, so we should reprofile after we
implement rule-bucketing.

Before
======
1
real    0m4.947s
user    0m9.201s
sys     0m0.326s

2
real    0m10.261s
user    0m16.571s
sys     0m0.449s

3
real    0m16.252s
user    0m25.140s
sys     0m0.637s

4
real    0m24.514s
user    0m37.832s
sys     0m0.793s

5
real    0m29.800s
user    0m46.636s
sys     0m1.584s

After
=====
1
real    0m3.557s
user    0m6.941s
sys     0m0.262s

2
real    0m5.431s
user    0m10.835s
sys     0m0.328s

3
real    0m9.191s
user    0m16.971s
sys     0m0.466s

4
real    0m12.106s
user    0m19.955s
sys     0m0.488s

5
real    0m15.732s
user    0m27.139s
sys     0m0.675s

Affected Paths:
   M //trunk/src/java/com/google/caja/parser/AbstractParseTreeNode.java
   M //trunk/src/java/com/google/caja/parser/ParseTreeNodes.java
   M //trunk/src/java/com/google/caja/util/SyntheticAttributes.java

Original issue reported on code.google.com by mikesamuel@gmail.com on 30 Apr 2008 at 4:47

GoogleCodeExporter commented 9 years ago

Original comment by ihab.a...@gmail.com on 30 Apr 2008 at 5:07

GoogleCodeExporter commented 9 years ago

Original comment by mikesamuel@gmail.com on 30 Apr 2008 at 8:12