search

honghaoz / Ji

Ji (戟) is an XML/HTML parser for Swift
MIT License
824 stars 64 forks source link

Carthage build issue #41

Open danielrhodes opened 7 years ago

danielrhodes commented 7 years ago

Since Swift isn't ABI stable yet, the prebuilt binaries that Carthage gets from Github on the releases page are not working with the latest versions of XCode/Swift. Would recommend that they be removed, as XCode won't build with them.

honghaoz commented 7 years ago

Hi @danielrhodes, thanks for your issue.

I tried with Carthage, the framework build by Carthage is good for me.

Here is my test project: TestJi.zip, works well.

What errors did you get?

danielrhodes commented 7 years ago

The error I got was that the project was built with Swift 3 and not 3.0.1. Not a source level issue, but whatever pre-built binaries you have on Github which Carthage is using instead of compiling the library locally.

honghaoz commented 7 years ago

@danielrhodes There's no pre-build binaries on GitHub, Carthage should build the framework locally.

I guess the error is caused by your target's Use Legacy Swift Language Version settings. Because setting to "No" in Xcode 8.2 results in SWIFT_VERSION = 3.0, while Xcode 8.1 sets to 3.0.1

danielrhodes commented 7 years ago

That is likely. My project is on 3.0.2.

honghaoz commented 7 years ago

Xcode 8.2 just uses SWIFT_VERSION = 3.0 instead of 3.0.x. Will you be able to provide a sample project with the error you met?