hongquan / CoBang

A QR code scanner desktop app for Linux
GNU General Public License v3.0
253 stars 26 forks source link

Consider the new version of Pillow (9.X) #53

Closed WolfangAukang closed 8 months ago

WolfangAukang commented 2 years ago

Thank you for the development of this application. Currently I'm porting it to Nixpkgs (https://github.com/NixOS/nixpkgs/pull/149729) and I can say it works as intended.

Unfortunately, the only reason I can't merge it yet is because Pillow has been recently updated to version 9.X. Not that I continuously use the application, but it would be something to consider for future versions, if possible.

Thank you!

hongquan commented 2 years ago

@WolfangAukang Sorry I reply late because I has been sick these days.

I will try to upgrade the Pillow dependency. It will take time because I need to package python3-pillow for Ubuntu as well.

hongquan commented 2 years ago

By the way, @WolfangAukang , could you try building CoBang with Pillow 9 in NixOS to see if it is compatible? I'm reluctant to add python3-pil v9 to Ubuntu because I worry it may break other softwares.

More info about my difficulty: Pillow 9 requires FreeType v2.8+, but the freetype in latest Ubuntu repo is v2.2.

WolfangAukang commented 2 years ago

Thanks for the reply @hongquan, and don't worry about it, it's just an enhancement request, so it is not urgent. And health first, so again, no rush :).

I have patched the pyproject.toml file to support Pillow ^9.0.0 and I can confirm it builds successfully, plus the image feature recognizes the QR perfectly. I can't test it with a camera because I don't have one, unfortunately.

WolfangAukang commented 2 years ago

FYI, CoBang is now available on the nixpkgs repository. It was recently merged.

hongquan commented 2 years ago

@WolfangAukang Great! Thanks.

I think, later on I will specify latest Pillow in pyproject.toml, but for Ubuntu package, I will choose the version in Ubuntu repository. It may help other distros do packaging easier.

hongquan commented 8 months ago

Done.