hongquanli / octopi-research

BSD 3-Clause "New" or "Revised" License
36 stars 36 forks source link

setup_octopi.sh: fail on errors, TRACE ability, and updated conda cuda package #113

Closed ianohara closed 3 weeks ago

ianohara commented 4 weeks ago

This makes the setup script fail on the first command that has an unchecked error, and makes tracing what's happening while debugging easier via the TRACE environment variable.

Also, while testing, the cudatoolkit=12.1 package failed (it looks like only up to 11.8 is on conda-forge and the nvidia channels), so this instead uses the cuda-version meta package to grab version 12.1. This part could be a mixup in my setup - if there's a channel with cudatoolkit=12.1 let me know!

NOTE: For a future pull request, regardless of the answer, it looks like we still install cuda relevant packages even if $INSTALL_CUDA is not specified. Is that intended?

Tested by:

  1. Running ./setup_octopi.sh without conda installed and making sure it fails with a non-zero error code, and prints a message.
  2. Running TRACE=1 ./setup_octopi.sh and making sure the + trace messages are shown
  3. Running ./setup_octopi.sh on an Ubuntu 22.04 system and making sure it runs successfully (after installing conda).