search

honmaple / emacs-maple-minibuffer

Show minibuffer with another frame
GNU General Public License v3.0
78 stars 4 forks source link

Ignore commands regexp #4

Closed seblemaguer closed 4 years ago

seblemaguer commented 4 years ago

Hello,

thanks for this nice feature.

While using it, I realized that "Helm-*" is not properly compatible with the current framework. To solve this, and be more general, I propose to filter commands based on a regular expression.

I also added a small change to be able to activate the mode using the daemon mode as well. Basically, it simply ignores the maple part if no graphic is detected.

honmaple commented 4 years ago

Thank you for you pr, this is a good idea, I have added the support of multi ignore regexp action

https://github.com/honmaple/emacs-maple-minibuffer/commit/cad327440a32dd69b54894b60718a02fa108ccbb

Please use (add-to-list 'maple-minibuffer:ignore-regexp "^helm-") and test it.

seblemaguer commented 4 years ago

Perfect for me. it works perfectly :)